fix: optional fields from publishConfig
#194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pi0 Could you review this, or should I merge the PR directly? |
Member
|
Please do not merge PRs unless you are explicit maintainer of repository. |
Member
Author
|
It's been over two months since I submitted PR #193. I've also pinged you during this time, but there hasn't been any response. If merging is an issue, I apologize and feel free to revert it. |
Member
|
PR is fine. I didn't merge because had to investigate why our tests didn't catch it). You could reach out again if it was a critical issue. we have several communication channels. As an open-source maintainer, you would understand why PRs can get delayed to land. ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.