-
Notifications
You must be signed in to change notification settings - Fork 25
feat: resolveWorkspace, resolveWorkspacePackages and resolveWorkspaceGraph
#247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fix: add `exports.types` field (unjs#120)
# Conflicts: # package.json # pnpm-lock.yaml
next we'll introduce changes from the previous contributor
remove for now, could be added in the future
35797c8 to
4059a87
Compare
missing nx and lerna support for now
first iteration, don't like some of the things.
todo: fix this mess, it's a good starting point tho
|
Thanks for resolving conflicts from the original PR. It might still take me longer to properly review, as I really want to make sure implementation is as minimal as possible. As an alternative direction we could publish it as a standalone package and probably if adopted host under unjs :) |
|
Sure, take your time - no rush at all! If we keep it minimal - I think keeping it here makes sense since it's mostly closely related to package.json handling and workspace detection that pkg-types already does to an extent |
|
Yeah, basic support makes sense. I'm also a little bit worried about the install size, too, though pkg-types is currently ~280kB and with tiny-globby ~158kB + bundled logic from PR (have to measure) we will be adding bytes that might not be used by big percentage of pkg-types users (or might be! that's also what we have to think more about) |
|
Unfortunately there's not really much to do. There's a tiny-glob package, which is really small (the smallest of them all afaik), but because of this is, it is sort of not reliable for production use, so currently tinyglobby provides the best of both world. Also |
|
Since glob is only needed for |
|
Sounds good. The only correction is that node.glob is 22x and above 😄 |
|
We could also implement an internal glob method as alternative. pathe (already a dep) supports |
|
This can work as well. But we need a crawler in that case. tinyglobby uses fdir, perhaps you've made one already inside unjs? |
resolveWorkspace, resolveWorkspacePackages and resolveWorkspaceGraph
|
|
resolves #117
continue from #118 (by @aa900031 ❤️)
based on the work from the previous contributor (preserving commit history). this update resolves merge conflicts, brings the implementation up to current state, and hopefully gets it ready for merge (keeping as draft to avoid getting distracted and jumping to other tasks lol).
this is mostly done. keeping this draft to shape the api, etc. I'll add/shape jsdocs/readme when this is good to go
p.s. regarding the ci, autofix action seem to override
lint:fixon his own. so in my case it was with the ruleunicorn/no-nested-ternary. I was adding it locally -> autofix ci job passes -> it removes those brackets causing a eslint problem we were trying to prevent