Skip to content

feat: detect cloudflare workers build ci#156

Merged
pi0 merged 1 commit intomainfrom
feat/cf-workers-ci
Apr 3, 2025
Merged

feat: detect cloudflare workers build ci#156
pi0 merged 1 commit intomainfrom
feat/cf-workers-ci

Conversation

@pi0
Copy link
Member

@pi0 pi0 commented Apr 3, 2025

Detect cloudflare worker builds CI using WORKERS_CI env (manual test, shows value is 1)

@pi0 pi0 requested a review from petebacondarwin April 3, 2025 22:36
@pi0 pi0 merged commit 55f2bae into main Apr 3, 2025
2 checks passed
@pi0 pi0 deleted the feat/cf-workers-ci branch April 3, 2025 22:38
teemingc added a commit to sveltejs/kit that referenced this pull request Feb 25, 2026
… for Cloudflare Workers (#13733)

Inspired by unjs/std-env#156

~This PR detects the `WORKERS_CI` environment variable so that
`adapter-auto` and `adapter-cloudflare` can work with Cloudflare's
[Workers Git
integration](https://developers.cloudflare.com/workers/ci-cd/builds/) to
build the app without requiring a wrangler configuration from the user.~

I've changed the scope of the PR to focus on only the Cloudflare adapter
because we'll may end up deprecating adapter-auto. Also, it doesn't work
well with adapter-auto since it requires a wrangler config file.

---

### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:
- [x] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it
solves.
- [x] Ideally, include a test that fails without this PR but passes with
it.

### Tests
- [ ] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`

### Changesets
- [x] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. Changesets that add features should be
`minor` and those that fix bugs should be `patch`. Please prefix
changeset messages with `feat:`, `fix:`, or `chore:`.

### Edits

- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.

---------

Co-authored-by: Chew Tee Ming <chew.tee.ming@nindatech.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant