feat: signJWT, verifyJWT and decodeJWT utils#23
Conversation
Co-authored-by: pooya parsa <pyapar@gmail.com>
|
@pi0 Suggestions implemented. Thanks for the guidance! |
|
@johannschopplich i think it is a still good idea sorry didn't have to check on it yet. Any reason you preferred to close? |
|
Hi there, @pi0! I didn't mean to close this PR... I deleted some forked repos from my GitHub account and wasn't aware that this PR would be closed as a result. No problem. I know you're working on a lot of projects and I don't have any expectations when contributing to OSS. 🙂 Having said that, I'm now using oslo/jwt for JWT handling. It's runtime-agnostic and feels a bit like an UnJS project. Should I open this PR again? |
|
Surely if you like to reopen i can handle the updates to merge as soon as could 👍🏼 I'm aware about oslo but kinda have some plans here that are unique ;) (Also we have OTP coming: #37) |
🔗 Linked issue
#17
❓ Type of change
📚 Description
Resolves #17.
The following JWT utilities will be available with this PR (migrated from
unjwt):signJWTverifyJWTdecodeJWTI have kept the code as simple as possible to cover the basic needs for JWT signing, verification and decoding. Method parameters have a balance between sensible defaults and customization.
Example usage:
Please verify if the general direction of this PR makes sense to you. If you, I'm willing to add tests as best as I can.
Notes
crypto.webandcrypto.nodetocrypto-web, respectivelycrypto-node, because unbuild v2 complained about the file extensions.unjwtpackage – explicitly withoutuncrypto, since I rely onunenvto resolve the usage von the Web Crypto API.jose, I successfully migrated to these new utilities. No user got logged out. 😋Questions
atobandbtoaare available in latest Node and worker versions, so I haven't added any usage ofbuffer. Is that OK for you?📝 Checklist