Open
Conversation
ernesto-jimenez
approved these changes
Jul 18, 2023
Contributor
ernesto-jimenez
left a comment
ernesto-jimenez
left a comment
There was a problem hiding this comment.
It works. Testing locally failed to print the name because we are yet to deploy the updated API endpoint.
Comment on lines
+60
to
+63
| res := &types.ProjectCreateResponse{} | ||
| if err = a.client.ExecuteRest(ctx, req, res); err != nil { | ||
| return types.Project{}, err | ||
| } |
Contributor
There was a problem hiding this comment.
question: do we prefer that format to this? Or we don't care either way?
var res types.ProjectCreateResponse
if err = a.client.ExecuteRest(ctx, req, &res); err != nil {
return types.Project{}, err
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
unweave initcommand to create a new project from the CLI