Update resolved bunyan version #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugnyan depends on bunyan
^1.8.1, which is resolved by yarn.lock to1.8.9.Bunyan depends on dtrace-provider
~0.8, which is resolved by debugnyan's yarn.lock to0.8.1.That version of dtrace-provider is not compatible with node 10. The fix has only been added to version
0.8.7.Version
~0.8also resolves to0.8.7, so there's no need to change the dependency version. We only need to update yarn's resolved version to have the newest dtrace-provider version available to debugnyan and its dependents.This PR's diff can be reviewed by deleting yarn.lock, running
yarnagain and checking the resolved version ofdtrace-provider(and its dependencynan) is exactly the same as the one in this diff.