Skip to content

Fixing dependency vulnerabilities #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SandroMachado merged 1 commit into from
Aug 30, 2019
Merged

Fixing dependency vulnerabilities #26

SandroMachado merged 1 commit into from
Aug 30, 2019

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 30, 2019

Description

These were found via yarn audit. Resolutions were added for packages with large amounts of varying sub-versions.

Before:
Screen Shot 2019-08-30 at 1 42 53 PM

After:
Screen Shot 2019-08-30 at 2 09 47 PM

Test Plan

  1. Pull this branch, run yarn && yarn audit
  2. Ensure that no vulnerabilities are found after the audit script
  3. Confirm that yarn lint && yarn test passes as expected

@SandroMachado SandroMachado merged commit accf1e4 into uphold:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SandroMachado SandroMachado SandroMachado approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanml @SandroMachado