Skip to content

Conversation

@Megamind51
Copy link
Contributor

@Megamind51 Megamind51 commented Dec 16, 2024

Add validator for Canada Postal Code.

BKO-5416

@Megamind51 Megamind51 force-pushed the support/add-canada-postal-code-assert branch from 3bdb700 to 56736fb Compare December 16, 2024 16:23
@KevinUphold
Copy link

LGTM.

@Megamind51 Megamind51 force-pushed the support/add-canada-postal-code-assert branch 3 times, most recently from 8a990a6 to ec43a5d Compare December 31, 2024 15:12
@vitorcoxta
Copy link

PR title and commit message suggestion:

Add Canada zip code assert

@Megamind51 Megamind51 changed the title Add Canada Postal Code assert Add Canada zip code assert Jan 2, 2025
@Megamind51 Megamind51 force-pushed the support/add-canada-postal-code-assert branch from ec43a5d to f0209c2 Compare January 2, 2025 13:22
Copy link

@vitorcoxta vitorcoxta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to be moved tested in backoffice and then moved to QA.

@Megamind51 Megamind51 force-pushed the support/add-canada-postal-code-assert branch from f0209c2 to c9b90d9 Compare January 13, 2025 15:40
Copy link

@antoniogferreira antoniogferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@vitorcoxta vitorcoxta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitorcoxta vitorcoxta merged commit 6b432e9 into master Jan 22, 2025
2 checks passed
@vitorcoxta vitorcoxta deleted the support/add-canada-postal-code-assert branch January 22, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants