Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new AnyOf assert to validator.js-asserts to allow validating that a value matches at least one of multiple constraint sets (similar to existing OneOf, but allowing multiple matches).
Changes:
- Introduced
AnyOfassert implementation that short-circuits on first matching constraint set and aggregates violations otherwise. - Exported
AnyOffrom the library entrypoint and updated the exported-asserts ordering/count test. - Added TypeScript typings and a dedicated test suite for
AnyOf.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/index.test.js | Updates exported asserts count and expected ordering to include AnyOf. |
| test/asserts/any-of-assert.test.js | Adds comprehensive tests for AnyOf behavior and violation reporting. |
| src/types/index.d.ts | Adds TS typing for anyOf(...constraintSets) on the asserts interface. |
| src/index.js | Exports the new AnyOf assert in stable alphabetical order. |
| src/asserts/any-of-assert.js | Implements the new AnyOf assert using validator.validate with deepRequired. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new assert to allow any of constraints (1 or more matches)
Added this here because https://github.com/uphold/paypal-client/pull/60 required this type of validation to have more readable code