Add https option to prevent handshake error #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fardog
approved these changes
Dec 7, 2017
.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| node_modules No newline at end of file | |||
Member
There was a problem hiding this comment.
nit: can we pull in a standard .gitignore for nodejs? https://github.com/github/gitignore/blob/master/Node.gitignore
fardog
approved these changes
Dec 8, 2017
GloriaAnholt
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that was happening on the latest node LTS.
This also updates the tests to fix an issue that was causing the gunzip stream to emit an error.
This also replaces a dev. dependency that was meant to find an open port to run a test server on, as the old one did not work on my machine and this new one seems to work everywhere.
I plan for this to be a patch release, once approved.