fix: disable shell completion if double dash is included in arguments (v3)

[suzuki-shunsuke]

What type of PR is this?

(REQUIRED)

• bug

What this PR does / why we need it:

(REQUIRED)

This pull request disables shell completion if double dash -- is included in arguments.
Arguments after double dash -- are not flags but positional arguments.

https://unix.stackexchange.com/a/11382

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1932

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

[dearchap]

@suzuki-shunsuke Did you want this for v2 or v3 ? If you want it for v2 you need to base off v2-maint branch. Also I would suggest you add some test cases.

[suzuki-shunsuke]

Thank you for your review.

suzuki-shunsuke Did you want this for v2 or v3 ? If you want it for v2 you need to base off v2-maint branch.

I think both v2 and v3 have this issue, so we should fix both v2 and v3.
I'll send a pull request to v2-maint too.

Also I would suggest you add some test cases.

Sure. I'll do it.

[dearchap]

v2 is in maint mode. No new features

[suzuki-shunsuke]

I think this is a bug fix rather than a new feature.
Are you not willing to accept this change to v2?

I'm using v2 because v3 is still alpha, but if v3 is stable I will upgrade v2 to v3.

[suzuki-shunsuke]

Also I would suggest you add some test cases.

a832345 I added tests.

The base branch is main, which means this pull request is for v3.

✅ I'll send another pull request for v2.

• fix: disable bash completion if double dash is included in arguments (v2) #1938