Fix:(issue_1925) Dont print default text for required flags#1935
Merged
dearchap merged 3 commits intourfave:mainfrom Jun 29, 2024
Merged
Fix:(issue_1925) Dont print default text for required flags#1935dearchap merged 3 commits intourfave:mainfrom
dearchap merged 3 commits intourfave:mainfrom
Conversation
ccoVeille
reviewed
Jun 28, 2024
Contributor
|
The default value for |
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Contributor
Author
Thats exactly why we need to mask it right ? |
meatballhat
approved these changes
Jun 29, 2024
Contributor
Maybe fail with an error then? |
Contributor
Author
This is to do with display and not the behavior of the flag itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1925
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
go test -run=ExampleCommand_Run_appHelp
Release Notes
(REQUIRED)