Fix: Make flags persistent by default

[dearchap]

What type of PR is this?

(REQUIRED)

• feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #976

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Updated existing tests to work with new features

Release Notes

(REQUIRED)

All flags defined by a command flow to subcommands by default unless the Local field is set for the flag in which case it will apply to that command only. This is better than having to make flags persistent when needed as this is an oft requested feature

[fiatjaf]

It doesn't work.

I'm on af97b3f. I created a directory example/ and put the following main.go file in it:

package main

import (
	"context"
	"fmt"
	"os"

	"github.com/urfave/cli/v3"
)

var app = &cli.Command{
	Name:                   "example",
	Suggest:                true,
	UseShortOptionHandling: true,
	Commands: []*cli.Command{
		blergh,
	},
}

var blergh = &cli.Command{
	Name: "blergh",
	Flags: []cli.Flag{
		&cli.BoolFlag{
			Name: "cool",
		},
		&cli.UintFlag{
			Name: "number",
		},
	},
	Action: func(ctx context.Context, c *cli.Command) error {
		fmt.Println("args:", c.Args())
		fmt.Println("cool?", c.Bool("cool"))
		fmt.Println("number", c.Uint("number"))

		return nil
	},
}

func main() {
	if err := app.Run(context.Background(), os.Args); err != nil {
		os.Exit(1)
	}
}

Then I run it with go run . blergh ok --cool --number 12, expecing the output to be

args: &{[ok]}
cool? true
number 12

But instead I get

args: &{[ok --cool --number 12]}
cool? false
number 0

[abitrolly]

I feel like this needs a proper blog post explaining the logic, without Go code.

[dearchap]

Okay I see the problem. I misinterpreted what you are looking for @fiatjaf . I'm going to reopen your PR and make a fix .