split template haskell stuff into sec-th #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steffen,
The current version of the sec package on Hackage still has the dependency on template-haskell 2.4, and so doesn't work with recent GHCs. I often find myself defining several of these SECs in every project I use, so it would be handy to have a package that pre-defines them that works with modern GHCs.
Even without the template haskell dependency issue (I see you liberalised the dependency to any 2.* version on github), it would be nice to be able to depend on this in packages I don't want to depend on template haskell at all. So I've taken the liberty of splitting the template haskell stuff into a separate package (see: https://github.com/cumber/sec-th).
If you agree, it would be great if you could pull this in and release it on Hackage. If you're no longer interested in maintaining this on Hackage, I'd be happy to take it over.
Cheers,
Ben