fix colors in dashboard by KMKoushik · Pull Request #206 · usesend/useSend

KMKoushik · 2025-08-30T04:18:05Z

Summary by CodeRabbit

Style
- Unified status badge colors across campaigns, contacts, domains, emails, and team lists for a more consistent theme.
- Replaced mixed/dark-mode-specific tokens with simplified palette (gray, green, red, yellow, blue, purple) across badges and indicators.
- Email charts now use theme-driven colors for Delivered, Bounced, Complained, Opened, and Clicked.
- Updated icon colors (Trash, Copy, Check) to match the new palette across delete/duplicate actions, payments, and templates.
- Visual tweaks only; no changes to behavior, data, or navigation.

coderabbitai · 2025-08-30T04:18:12Z

Walkthrough

System-wide UI styling updates replace specific Tailwind color shades with simplified tokens and theme-driven colors. Multiple badges and icons switch palettes. Minor formatting adds trailing commas in mutation options without behavior changes. Email chart now derives colors via useColors with a helper mapping statuses to theme colors. No public APIs changed.

Changes

Cohort / File(s)	Summary
Campaign status badges `apps/web/src/app/(dashboard)/campaigns/[campaignId]/page.tsx`, `apps/web/src/app/(dashboard)/campaigns/campaign-list.tsx`	Updated badge color tokens across statuses to new gray/green/red/blue/purple/yellow palette; simplified classes; no logic changes.
Campaign actions (formatting/icons) `apps/web/src/app/(dashboard)/campaigns/delete-campaign.tsx`, `apps/web/src/app/(dashboard)/campaigns/duplicate-campaign.tsx`	Added trailing commas in mutate options; updated icon colors (red/blue) tokens; no behavioral changes.
Contacts UI updates `apps/web/src/app/(dashboard)/contacts/[contactBookId]/contact-list.tsx`	Simplified Subscribed/Unsubscribed badge classes to flat tokens; minor trailing comma; no logic changes.
Contacts actions (formatting/icons) `apps/web/src/app/(dashboard)/contacts/[contactBookId]/delete-contact.tsx`, `apps/web/src/app/(dashboard)/contacts/delete-contact-book.tsx`	Trailing commas in mutate/options and parameter lists; updated Trash icon colors; no behavioral changes.
Domains status visuals `apps/web/src/app/(dashboard)/domains/[domainId]/page.tsx`, `apps/web/src/app/(dashboard)/domains/domain-badge.tsx`, `apps/web/src/app/(dashboard)/domains/status-indicator.tsx`	Reworked badge/indicator color mappings to simplified tokens; removed dark-mode variants; minor formatting; control flow unchanged.
Email chart theming `apps/web/src/app/(dashboard)/dashboard/email-chart.tsx`	Replaced fixed colors with theme via useColors; added local status→color helper; adjusted tooltip/dot rendering to inline styles; no API changes.
Emails list and actions `apps/web/src/app/(dashboard)/emails/email-list.tsx`, `apps/web/src/app/(dashboard)/emails/cancel-email.tsx`	Generalized icon color classes; added trailing commas; date formats unchanged; no logic changes.
Templates pages/actions `apps/web/src/app/(dashboard)/templates/[templateId]/edit/page.tsx`, `apps/web/src/app/(dashboard)/templates/delete-template.tsx`, `apps/web/src/app/(dashboard)/templates/duplicate-template.tsx`	Formatting-only trailing commas; status dot colors switched to yellow/green tokens; updated Trash/Copy icon colors; behavior unchanged.
Dev settings: API keys `apps/web/src/app/(dashboard)/dev-settings/api-keys/add-api-key.tsx`, `apps/web/src/app/(dashboard)/dev-settings/api-keys/delete-api-key.tsx`	Trailing commas in mutate options; updated Check/Trash icon colors; no logic changes.
Team management UI `apps/web/src/app/(dashboard)/settings/team/delete-team-invite.tsx`, `apps/web/src/app/(dashboard)/settings/team/delete-team-member.tsx`, `apps/web/src/app/(dashboard)/settings/team/team-members-list.tsx`	Added trailing commas; simplified Active/Pending badge classes; updated icon colors; no functional changes.
Payments UI `apps/web/src/app/(dashboard)/payments/page.tsx`, `apps/web/src/components/payments/PlanDetails.tsx`, `apps/web/src/components/payments/UpgradeModal.tsx`	Updated Check icons to new green token; structure and behavior unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant EmailChart as EmailChart
  participant useColors as Theme Colors
  participant Item as EmailChartItem
  participant Tooltip as Tooltip/UI

  EmailChart->>useColors: get currentColors
  loop for each metric/status
    EmailChart->>Item: render(status, value, currentColors)
    Item->>Item: getColorForStatus(status, currentColors)
    Item-->>EmailChart: color string
  end
  EmailChart->>Tooltip: render entries with inline style background using color
  Tooltip-->>EmailChart: visible themed legend/dots

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: make billing better #203 — Similar payment UI tweaks updating icon color tokens in PlanDetails.tsx and UpgradeModal.tsx.

Poem

I hopped through hues of red and green,
Swapped cyan’s coat for blue’s new sheen.
Badges gleam, the charts align,
Colors now from themes divine.
Trailing commas, tidy, neat—
Thump-thump, this merge feels extra sweet! 🐇🎨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch km/2025-08-27-dashboard-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 5

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

apps/web/src/app/(dashboard)/contacts/[contactBookId]/contact-list.tsx (1)
108-108: Typo: border-broder → border-border.

The container loses its border because of the misspelling.

Apply this diff:
-        <div className="flex flex-col rounded-xl border border-broder shadow">
+        <div className="flex flex-col rounded-xl border border-border shadow">
apps/web/src/app/(dashboard)/dashboard/email-chart.tsx (1)
291-294: Guard against non-finite percentages to prevent crashes.

If total sent is 0 but a numerator > 0, percentage can be Infinity and toFixed will throw. Add a finite check.

Apply this diff:
-            {status !== "total"
-              ? `(${count > 0 ? (percentage * 100).toFixed(0) : 0}%)`
-              : null}
+            {status !== "total"
+              ? `(${
+                  count > 0 && Number.isFinite(percentage)
+                    ? (percentage * 100).toFixed(0)
+                    : 0
+                }%)`
+              : null}

🧹 Nitpick comments (11)

apps/web/src/components/payments/UpgradeModal.tsx (1)
55-55: Hide decorative check icon from screen readers.

The icon is purely presentational next to text; mark it decorative.

Apply:
-                  <CheckCircle2 className="h-4 w-4 text-green flex-shrink-0 mt-0.5" />
+                  <CheckCircle2 aria-hidden="true" className="h-4 w-4 text-green flex-shrink-0 mt-0.5" />
apps/web/src/components/payments/PlanDetails.tsx (1)
39-39: Hide decorative check icon from screen readers.

Improve a11y for the perks list.

Apply:
-            <CheckCircle2 className="h-4 w-4 text-green flex-shrink-0" />
+            <CheckCircle2 aria-hidden="true" className="h-4 w-4 text-green flex-shrink-0" />
apps/web/src/app/(dashboard)/payments/page.tsx (1)
40-40: Hide decorative success icon from screen readers.

Mark the success icon decorative; the adjacent text conveys the message.

Apply:
-          <CheckCircle2 className="h-4 w-4 text-green flex-shrink-0" />
+          <CheckCircle2 aria-hidden="true" className="h-4 w-4 text-green flex-shrink-0" />
apps/web/src/app/(dashboard)/templates/duplicate-template.tsx (1)
32-39: Surface errors on duplicate failure

Consider adding onError to inform users if duplication fails.
       {
         onSuccess: () => {
           utils.template.getTemplates.invalidate();
           setOpen(false);
           toast.success(`Template duplicated`);
         },
+        onError: (e) => {
+          toast.error(`Template not duplicated: ${e.message ?? "Unknown error"}`);
+        },
       },
apps/web/src/app/(dashboard)/domains/status-indicator.tsx (2)
6-23: Simplify color mapping

A small map is clearer and type-safe.
-  let badgeColor = "bg-gray"; // Default color
-  switch (status) {
-    case DomainStatus.NOT_STARTED:
-      badgeColor = "bg-gray";
-      break;
-    case DomainStatus.SUCCESS:
-      badgeColor = "bg-green";
-      break;
-    case DomainStatus.FAILED:
-      badgeColor = "bg-red";
-      break;
-    case DomainStatus.TEMPORARY_FAILURE:
-    case DomainStatus.PENDING:
-      badgeColor = "bg-yellow";
-      break;
-    default:
-      badgeColor = "bg-gray";
-  }
+  const colorByStatus: Record<DomainStatus, string> = {
+    [DomainStatus.NOT_STARTED]: "bg-gray",
+    [DomainStatus.SUCCESS]: "bg-green",
+    [DomainStatus.FAILED]: "bg-red",
+    [DomainStatus.TEMPORARY_FAILURE]: "bg-yellow",
+    [DomainStatus.PENDING]: "bg-yellow",
+  };
+  const badgeColor = colorByStatus[status] ?? "bg-gray";
6-23: Decorative-only indicator: mark hidden from a11y tree

If a textual status label is adjacent, hide this purely visual bar from assistive tech.
-  return <div className={` w-[2px] ${badgeColor} my-1.5 rounded-full`}></div>;
+  return (
+    <div
+      role="presentation"
+      aria-hidden="true"
+      className={`w-[2px] ${badgeColor} my-1.5 rounded-full`}
+    />
+  );
apps/web/src/app/(dashboard)/campaigns/campaign-list.tsx (1)

105-110: Status badge token swap looks good; consider centralizing badge variants.

The new bg/text/border tokens align with the PR’s theme direction. Consider extracting a small Badge component or a status→class map to keep variants consistent across screens.

apps/web/src/app/(dashboard)/contacts/[contactBookId]/contact-list.tsx (1)

89-101: Minor consistency nit: “All” vs “all”.

Other pages (e.g., campaigns list) use "all" (lowercase) in Select values. Aligning here would reduce mental overhead when scanning URL params and handlers.

apps/web/src/app/(dashboard)/dashboard/email-chart.tsx (1)

255-273: Local status→color mapping works; consider deduping.

getColorForStatus mirrors logic likely used by EmailStatusIcon. To avoid drift, consider moving this mapping next to useColors() (e.g., export a helper) and reusing it here and in icons.
apps/web/src/app/(dashboard)/settings/team/delete-team-member.tsx (2)
41-41: Trailing comma: fine; tiny polish opportunity in handlers

No behavior change—good for diffs. Minor nit: the onSuccess/onError callbacks are marked async but don’t await anything. Either await the invalidate or drop async to avoid implied floating promises.

Example outside this line range:
onSuccess: async () => {
  await utils.team.getTeamUsers.invalidate();
  setOpen(false);
  toast.success("Team member removed successfully");
},
onError: (error) => {
  toast.error(error.message);
},
53-53: Prefer semantic tokens for destructive color; add accessible label on icon-only trigger

If your theme exposes a semantic token (e.g., text-destructive), use that over raw red for consistency and theming. Also, this trigger is icon-only—add an accessible name.

Proposed diff within this block:
-        <Button variant="ghost" size="sm">
+        <Button
+          variant="ghost"
+          size="sm"
+          aria-label={self ? "Leave team" : "Remove team member"}
+        >
-            <LogOut className="h-4 w-4 text-red/80" />
+            <LogOut className="h-4 w-4 text-destructive/80" />
...
-            <Trash2 className="h-4 w-4 text-red/80" />
+            <Trash2 className="h-4 w-4 text-destructive/80" />
If text-destructive isn’t defined, please confirm that text-red (without shade) is configured with a DEFAULT in your Tailwind theme so text-red/80 compiles as intended.

Also applies to: 55-55

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 55d2a10 and a54b830.

📒 Files selected for processing (24)

apps/web/src/app/(dashboard)/campaigns/[campaignId]/page.tsx (1 hunks)
apps/web/src/app/(dashboard)/campaigns/campaign-list.tsx (1 hunks)
apps/web/src/app/(dashboard)/campaigns/delete-campaign.tsx (2 hunks)
apps/web/src/app/(dashboard)/campaigns/duplicate-campaign.tsx (2 hunks)
apps/web/src/app/(dashboard)/contacts/[contactBookId]/contact-list.tsx (1 hunks)
apps/web/src/app/(dashboard)/contacts/[contactBookId]/delete-contact.tsx (2 hunks)
apps/web/src/app/(dashboard)/contacts/delete-contact-book.tsx (3 hunks)
apps/web/src/app/(dashboard)/dashboard/email-chart.tsx (6 hunks)
apps/web/src/app/(dashboard)/dev-settings/api-keys/add-api-key.tsx (2 hunks)
apps/web/src/app/(dashboard)/dev-settings/api-keys/delete-api-key.tsx (2 hunks)
apps/web/src/app/(dashboard)/domains/[domainId]/page.tsx (6 hunks)
apps/web/src/app/(dashboard)/domains/domain-badge.tsx (1 hunks)
apps/web/src/app/(dashboard)/domains/status-indicator.tsx (1 hunks)
apps/web/src/app/(dashboard)/emails/cancel-email.tsx (2 hunks)
apps/web/src/app/(dashboard)/emails/email-list.tsx (4 hunks)
apps/web/src/app/(dashboard)/payments/page.tsx (1 hunks)
apps/web/src/app/(dashboard)/settings/team/delete-team-invite.tsx (2 hunks)
apps/web/src/app/(dashboard)/settings/team/delete-team-member.tsx (2 hunks)
apps/web/src/app/(dashboard)/settings/team/team-members-list.tsx (2 hunks)
apps/web/src/app/(dashboard)/templates/[templateId]/edit/page.tsx (6 hunks)
apps/web/src/app/(dashboard)/templates/delete-template.tsx (2 hunks)
apps/web/src/app/(dashboard)/templates/duplicate-template.tsx (2 hunks)
apps/web/src/components/payments/PlanDetails.tsx (1 hunks)
apps/web/src/components/payments/UpgradeModal.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

{apps,packages}/**/*.{js,jsx,ts,tsx,css,scss,md,mdx}