-
-
Notifications
You must be signed in to change notification settings - Fork 358
feat: Add email-password authentication #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
77f4af5
feat(auth): add email-password authentication
Divkix 95eafbc
feat(settings): add account settings with password management
Divkix 4901e30
feat(security): add rate limiting for credentials auth
Divkix 48e480c
fix(security): address PR review security and code quality issues
Divkix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
apps/web/prisma/migrations/20251219093000_add_password_auth/migration.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| -- AlterTable | ||
| ALTER TABLE "User" ADD COLUMN "passwordHash" TEXT; | ||
|
|
||
| -- CreateTable | ||
| CREATE TABLE "PasswordResetToken" ( | ||
| "id" TEXT NOT NULL, | ||
| "email" TEXT NOT NULL, | ||
| "token" TEXT NOT NULL, | ||
| "expires" TIMESTAMP(3) NOT NULL, | ||
| "createdAt" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
|
|
||
| CONSTRAINT "PasswordResetToken_pkey" PRIMARY KEY ("id") | ||
| ); | ||
|
|
||
| -- CreateIndex | ||
| CREATE UNIQUE INDEX "PasswordResetToken_token_key" ON "PasswordResetToken"("token"); | ||
|
|
||
| -- CreateIndex | ||
| CREATE INDEX "PasswordResetToken_email_idx" ON "PasswordResetToken"("email"); | ||
|
|
||
| -- CreateIndex | ||
| CREATE UNIQUE INDEX "PasswordResetToken_email_token_key" ON "PasswordResetToken"("email", "token"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PasswordResetToken model is missing an index on the expires field. This field is frequently queried for validation (checking if tokens have expired) and would benefit from an index to optimize these lookups. Additionally, a periodic cleanup job that deletes expired tokens would also benefit from this index.
Consider adding @@index([expires]) to improve query performance for expiration checks and cleanup operations.