Fix rascal summary#2630
Merged
DavyLandman merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Member
|
That's cool. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6658 6653 -5
=======================================
Files 795 795
Lines 65856 65856
Branches 9871 9871
=======================================
+ Hits 30643 30649 +6
+ Misses 32847 32842 -5
+ Partials 2366 2365 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PaulKlint
reviewed
Feb 4, 2026
Member
PaulKlint
left a comment
There was a problem hiding this comment.
Looks fine to me. Good that you fixed the tests (although I don't think we run them by default)
For the record: if ever performance issues will occur for makeSummary, we might opt to only convert the result of makeSummary and not the complete TModel
PaulKlint
approved these changes
Feb 4, 2026
PaulKlint
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rascal summary now uses physical locations instead of logical ones