#2346 redone: a formatter for Rascal itself, plus the necessary improvements and stabilization in the Box formatter framework code.

[jurgenvinju]

This is a redo of #2346 which was mangled due to a wrong use of git-filter-repo.

Rascal is a pretty big language so this pushes the new toBox and format and layoutDiff functions to the max.

• The goal is to formulate toBox rules such that the formatter produces beautiful layout, and
• We identify bugs and efficiency issues in toBox, format and layoutDiff and fix them immediately.
• We add box operators with variable argument lists to eliminate a level of superfluous brackets
• We test for exceptions, parse errors and comment preservation, on all files of the standard library and the larger files in the Compiler and checker.
• re-implementation (optimized) of U and G
• integration tests succeed https://github.com/usethesource/rascal-core-big-tests/actions/runs/23592431666

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46%. Comparing base (3846a40) to head (60002de).

Additional details and impacted files

@@           Coverage Diff           @@
##              main   #2738   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6728    6737    +9     
=======================================
  Files          794     794           
  Lines        65923   65936   +13     
  Branches      9888    9888           
=======================================
+ Hits         30839   30857   +18     
+ Misses       32699   32691    -8     
- Partials      2385    2388    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jurgenvinju]

thanks for the review @toinehartman . Before we merge, some of the TODOs @toinehartman highlighted should be checked. See the conversation above.

[jurgenvinju]

@DavyLandman this seems ready. lots of fixes in Box-related code, fixed in layoutDif, and new features for Rascal formatting.

[toinehartman]

Nice to see the declarative formatting nearing completion! I just have some small remarks.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud