Several QoL (quality of life) improvements#56
Merged
hiimchrislim merged 11 commits intoutmgdsc:dev/gdsc-open-source-2022from Jan 11, 2023
Merged
Several QoL (quality of life) improvements#56hiimchrislim merged 11 commits intoutmgdsc:dev/gdsc-open-source-2022from
hiimchrislim merged 11 commits intoutmgdsc:dev/gdsc-open-source-2022from
Conversation
hiimchrislim
reviewed
Oct 9, 2022
hiimchrislim
reviewed
Oct 9, 2022
hiimchrislim
reviewed
Oct 9, 2022
hiimchrislim
requested changes
Oct 9, 2022
Member
hiimchrislim
left a comment
hiimchrislim
left a comment
There was a problem hiding this comment.
Left a few comments to review.
embeddedt
requested review from
hiimchrislim
and removed request for
shubhbapna
Students were getting confused and thinking they had selected an option when they were really just hovering on it. Also, touching the option results in it remaining "hovered" even after the finger is long gone.
This is done in addition to changing the title as was done previously.
* Use document.visibilityState to determine when the tab is not focused. This avoids a race condition where the tab is unfocused before the page has loaded, so the app can't detect it. Also, this lets us get rid of an event handler. * Forcefully close the notification that was previously open, to improve reliability of seeing the new notification.
embeddedt
force-pushed
the
qol-improvements
branch
from
444aaa5 to
e10b80f
Compare
Member
|
Will be looking at this during the weekend. (A bit busy at work atm) |
Member
|
@hiimchrislim are you able to check this? |
Collaborator
|
@embeddedt is it possible to open the PR against gdsc open source branch. I want to include this in the next release scheduled for first of week of winter |
Author
|
I switched the base and the commits seem to still be intact; let me know if I still need to create a new PR. |
hiimchrislim
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Tests
Please describe the tests that you ran to verify your changes.