Skip to content

Linting and Formatting for the backend#71

Merged
shubhbapna merged 4 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:backend-lint
Oct 25, 2022
Merged

Linting and Formatting for the backend#71
shubhbapna merged 4 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:backend-lint

Conversation

@ggggg
Copy link
Collaborator

@ggggg ggggg commented Oct 10, 2022

Fixes

Issue #62

Proposed Changes

  • Adds linting to the backend
  • Adds linting CI using github actions

Tests

Please describe the tests that you ran to verify your changes.

  • Compiled typescript via yarn run build to make sure no type errors are caused
  • Ran eslint style checks

@ggggg
Copy link
Collaborator Author

ggggg commented Oct 10, 2022

Note: This PR is missing husky integration

@hiimchrislim
Copy link
Member

hiimchrislim commented Oct 11, 2022

If possible, could you also add in the Husky integration with this? Thanks!

@ggggg
Copy link
Collaborator Author

ggggg commented Oct 11, 2022

If possible, could you also add in the Husky integration with this? Thanks!

No because I cant get it to work on windows, this could be a separate issue.

@shubhbapna
Copy link
Collaborator

Husky with github desktop seems to be a known issue with some working hacks

Try:
typicode/husky#1163
https://stackoverflow.com/questions/66520423/github-desktop-husky-pre-commit-hook-does-not

@ggggg ggggg requested review from shubhbapna and removed request for hiimchrislim October 12, 2022 06:00
@hiimchrislim
Copy link
Member

hiimchrislim commented Oct 14, 2022

No because I cant get it to work on windows, this could be a separate issue.

What errors are you encountering with Husky on Windows?

@ggggg
Copy link
Collaborator Author

ggggg commented Oct 14, 2022

Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhbapna
Copy link
Collaborator

For next time please try to resolve such issues

You will definitely come across projects where you might not be able to setup your dev environment as smoothly. But it is definitely worth setting up your dev env correctly otherwise your PRs might be blocked until their standards are met.

But congrats on your first PR!

@shubhbapna shubhbapna merged commit ecb4c4f into utmgdsc:dev/gdsc-open-source-2022 Oct 25, 2022
@ggggg ggggg deleted the backend-lint branch October 25, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants