Make sure polling results are only sent to instructors#76
Merged
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from Jan 6, 2023
Merged
Conversation
ggggg
reviewed
Oct 23, 2022
server/src/server.ts
Outdated
| }); | ||
| io.use(async (socket, next) => { | ||
| const userType = await getUser(socket.data.utorid); | ||
| socket.data["userType"] = userType.data.userType; |
Collaborator
There was a problem hiding this comment.
Why not do this in the first place?
Suggested change
| socket.data["userType"] = userType.data.userType; | |
| socket.data.userType = userType.data.userType; |
Author
There was a problem hiding this comment.
I was preserving the code style from line 50, where the assignment seems to use the [""] notation.
shubhbapna
requested changes
Dec 21, 2022
Collaborator
shubhbapna
left a comment
shubhbapna
left a comment
There was a problem hiding this comment.
@embeddedt I would like to include this PR even when we need #82 because we just want to show the results when the prof presses the button. Could you:
- Change the target branch to the open source branch
- Create
types/user.types.tsand store a UserType enum instead of using literal strings
embeddedt
force-pushed
the
fix-network-traffic
branch
from
c6643cb to
10f2030
Compare
embeddedt
force-pushed
the
fix-network-traffic
branch
from
10f2030 to
789f61e
Compare
embeddedt
requested review from
shubhbapna
and removed request for
hiimchrislim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered while testing the fix for #50, add socket.io rooms for each user type, and ensure that
resultmessages are only sent to the instructor room.The user type is fetched once on socket connection and then cached, which means this approach should not add additional load to each vote.