Skip to content

Changed char set (see #77)#83

Merged
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:new-char-set
Nov 9, 2022
Merged

Changed char set (see #77)#83
shubhbapna merged 2 commits intoutmgdsc:dev/gdsc-open-source-2022from
ggggg:new-char-set

Conversation

@ggggg
Copy link
Collaborator

@ggggg ggggg commented Nov 2, 2022

This template is a simple version of Zulip PR template: https://github.com/zulip/zulip/

Changed character set: from lowercase letters and numbers to just uppercase letters to improve readability.

Fixes: #77

Screenshots and screen captures:

Self-review checklist

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review:

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes (what you are trying to accomplish? e.g. don't let user's age less than 0).

Completed manual review and testing of the following (please attach screenshots/gifs for UI changes and commit your test cases for functionality changes):

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhbapna shubhbapna merged commit 0055134 into utmgdsc:dev/gdsc-open-source-2022 Nov 9, 2022
@ggggg ggggg deleted the new-char-set branch November 9, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants