Skip to content

Conversation

@PMohanJ
Copy link
Contributor

@PMohanJ PMohanJ commented Oct 14, 2022

What does this PR do?

Implemented linter for the repository

Related PRs and Issues

appwrite/appwrite/issues/4359

Have you read the Contributing Guidelines on issues?

Yes

@PMohanJ
Copy link
Contributor Author

PMohanJ commented Oct 15, 2022

Hi @Meldiron! I've formatted the existing code. Apologies for messing up a little bit, as I'm not well aware of composer.lock file.

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@Meldiron
Copy link
Contributor

@PMohanJ No worries, you have done amazing work 😇 I have added lockfile changes. There is a lot of them but we, as developers, ignore them. They are auto-generated and they help us ensure a release keeps working forever, no matter the dependency versioning.

@christyjacob4
Copy link
Contributor

@PMohanJ please resolve the conflicts

@PMohanJ PMohanJ closed this Dec 20, 2022
@PMohanJ PMohanJ force-pushed the feat-code-formatter branch from 75f2714 to 6370d91 Compare December 20, 2022 15:09
@PMohanJ
Copy link
Contributor Author

PMohanJ commented Dec 20, 2022

@christyjacob4 Hi, I was actually trying to pull the updates from the origin repository, as after my PR there were some modifications to the origin repo. But unfortunately my PR commits were deleted. Would my suggesting what I am supposed to now, like, should I open a new PR?

@PMohanJ PMohanJ reopened this Dec 23, 2022
@PMohanJ
Copy link
Contributor Author

PMohanJ commented Dec 23, 2022

@christyjacob4 I reopened the PR with required modifications. Please review it again.

@christyjacob4 christyjacob4 merged commit 42fa78f into utopia-php:master Jan 10, 2023
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/abuse’

3 participants