Skip to content

Conversation

@Meldiron
Copy link
Collaborator

@Meldiron Meldiron commented Oct 16, 2023

  • Manual QA with Sentry logging
    CleanShot 2023-10-17 at 15 24 00@2x
    CleanShot 2023-10-17 at 15 24 29@2x
  • All tests in utopia/database passed locally
    image

@Meldiron Meldiron reopened this Oct 16, 2023
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Let's make sure all those tests are added and the auth var issues are sorted too 👍

@Meldiron
Copy link
Collaborator Author

This is going to be a lot of maintenance overhead 😅 we'll need to update any time any parameter in the database library is added, changed, or removed.

Yes, sadly. We could just proxy it, but we won't have any validators and we would be guessing expected classes. That'ß why we decided to define each endpoint.

Thankfully, if you do some change or add new method in utopia-php/database, the DatabaseProxy tests will fails. Thats indicator that you need to add it here too.

@eldadfux eldadfux merged commit 85812cd into main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants