Skip to content

Conversation

@Meldiron
Copy link
Collaborator

@Meldiron Meldiron commented Mar 1, 2024

In coroutine style server, we arent scared of long-runnign requests.
Instead of dropping request, we give it more time to wait for available connection. This will cause long response times instead of instant 4XX / 5XX errors.

@Meldiron
Copy link
Collaborator Author

Meldiron commented Mar 1, 2024

QA:

(considering pool size 256)
Without this PR, 1000 VUs: 2 300 req per sec, 96.43% success rate, avg=427.13ms, max=3.58s
With this PR, 1000 VUs: 1 637 req per sec, 99.96% sucess rate, avg=611.81ms, max=32s

Those stats prove the change behaves as expected

@eldadfux eldadfux merged commit d13d7cf into main Mar 1, 2024
@christyjacob4 christyjacob4 deleted the feat-pools-retry branch March 1, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants