Skip to content

Indexes for permissions #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 8 commits into from
Jun 9, 2023
Merged

Indexes for permissions #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7db34ea
composer.lock
fogelito Mar 20, 2023
4be3d49
Merge branch 'main' of github.com:utopia-php/database into permission…
fogelito Mar 20, 2023
87149e2
indexes
fogelito Mar 20, 2023
bdcb152
remove var_dump
fogelito Mar 20, 2023
208d907
extra line :)
fogelito Mar 20, 2023
1bea2b5
New rule
fogelito Mar 21, 2023
f961f3d
composer.lock
fogelito May 29, 2023
b3b972d
Merge branch 'main' of github.com:utopia-php/database into permission…
fogelito May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/tasks/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ function addArticle($database, Generator $faker): void
// Three random users out of 10,000 get mutate access

'$permissions' => [
Permission::read(Role::any()),
Permission::read(Role::user($faker->randomNumber(4))),
Permission::read(Role::user($faker->randomNumber(4))),
Permission::read(Role::user($faker->randomNumber(4))),
Expand Down
2 changes: 1 addition & 1 deletion src/Database/Adapter/MariaDB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public function createCollection(string $name, array $attributes = [], array $in
`_document` VARCHAR(255) NOT NULL,
PRIMARY KEY (`_id`),
UNIQUE INDEX `_index1` (`_document`,`_type`,`_permission`),
INDEX `_permission` (`_permission`)
INDEX `_permission` (`_permission`,`_type`,`_document`)
)")
->execute();
} catch (\Exception $th) {
Expand Down
21 changes: 12 additions & 9 deletions src/Database/Adapter/Postgres.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,18 @@ public function createCollection(string $name, array $attributes = [], array $in
$stmt->execute();
$stmtIndex->execute();

$this->getPDO()->prepare("
CREATE TABLE IF NOT EXISTS {$this->getSQLTable($id . '_perms')} (
\"_id\" SERIAL NOT NULL,
\"_type\" VARCHAR(12) NOT NULL,
\"_permission\" VARCHAR(255) NOT NULL,
\"_document\" VARCHAR(255) NOT NULL,
PRIMARY KEY (\"_id\")
);
")->execute();
$this->getPDO()
->prepare("CREATE TABLE IF NOT EXISTS {$this->getSQLTable($id . '_perms')} (
\"_id\" SERIAL NOT NULL,
\"_type\" VARCHAR(12) NOT NULL,
\"_permission\" VARCHAR(255) NOT NULL,
\"_document\" VARCHAR(255) NOT NULL,
PRIMARY KEY (\"_id\")
);
CREATE UNIQUE INDEX \"index_{$namespace}_{$id}_ukey\" ON {$this->getSQLTable($id. '_perms')} USING btree (\"_document\",\"_type\",\"_permission\");
CREATE INDEX \"index_{$namespace}_{$id}_permission\" ON {$this->getSQLTable($id. '_perms')} USING btree (\"_permission\",\"_type\",\"_document\");
")
->execute();

foreach ($indexes as $index) {
$indexId = $this->filter($index->getId());
Expand Down