Skip to content

Conversation

@faisalill
Copy link
Contributor

@faisalill faisalill commented May 27, 2023

@abnegate

What's changed:

  1. Added the code to connect to different adapters that are allowed.
  2. Added Database, Attributes, Index, relationship and document methods.

@faisalill
Copy link
Contributor Author

faisalill commented May 30, 2023

@abnegate,
Did the changes as you mentioned.

@faisalill
Copy link
Contributor Author

@abnegate ,
Did the changes as you said.

@stnguyen90 stnguyen90 self-requested a review July 17, 2023 18:47
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 I left some comments during the review, please check them out.

@gewenyu99
Copy link

I have no comments beyond what has been mentioned by Steven. Great PR!

Add Table of contents for readme.md and contributing.md

Update limitations for mariadb,mysql,postgres,sqlite and mongodb

Add tests in contributing.md

Add contributing section in readme.md

Fix code as per review from steven
@faisalill faisalill requested a review from stnguyen90 July 18, 2023 18:22
Remove table of contents from readme.md and contributing.md

Change supported databases table from horizontal to vertical.

Fix improper headings and title cases
@faisalill faisalill requested a review from stnguyen90 July 19, 2023 02:26
@faisalill faisalill requested a review from adityaoberai July 21, 2023 12:41
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment: #277 (comment)

Otherwise, this looks beautiful!

@faisalill faisalill requested a review from abnegate July 22, 2023 15:42
@faisalill faisalill requested a review from abnegate July 26, 2023 02:05
@abnegate abnegate requested a review from stnguyen90 July 26, 2023 19:01
@abnegate abnegate merged commit 540ec7e into utopia-php:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants