No Exception when no change in update document function #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
requested changes
Jul 18, 2023
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
approved these changes
Jul 24, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
LGTM. I'll defer to @abnegate for another set of eyes.
fogelito
reviewed
Jul 25, 2023
abnegate
reviewed
Jul 25, 2023
Contributor
Author
|
@abnegate can you please re-review this |
abnegate
approved these changes
Jul 26, 2023
This was referenced Aug 1, 2023
abnegate
deleted the
fix-no-authorization-exception-no-change-update-document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not throw authorization exception when there is no change in update document coming document.
This is required for Relationships as we need to allow users to update document having related collection with no permission.
Part fix appwrite/appwrite#5404