Fix 5871 relationships with non existing documents #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to many relationships
fanatic75
commented
Jul 27, 2023
fanatic75
commented
Jul 27, 2023
fanatic75
commented
Jul 27, 2023
fanatic75
commented
Jul 27, 2023
stnguyen90
reviewed
Jul 27, 2023
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
reviewed
Jul 29, 2023
Previously we were getting 500 as the non existing doc needs to be updated in two-way relationship type and non existing doc does not have key. Now we are keeping it consistent with other relationship types and skipping non existing doc
abnegate
reviewed
Aug 7, 2023
abnegate
approved these changes
Aug 9, 2023
2 tasks
abnegate
deleted the
fix-5871-relationships-with-non-existing-documents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug in multiple relationships
Fixes 🐛 Bug Report: Many-to-Many Relationship Updated with Non Existing Documents appwrite/appwrite#5871
Previously we were getting 500 for one to one two way as the non existing doc needs to be updated in One to One two-way relationship type and non existing doc does not have key.
Now we are keeping it consistent with other relationship types and skipping non existing doc