Skip to content

Improve Select Query #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abnegate merged 1 commit into from
Aug 9, 2023
Merged

Improve Select Query #299

abnegate merged 1 commit into from
Aug 9, 2023

Conversation

@faisalill
Copy link
Contributor

@faisalill faisalill commented Jul 30, 2023 •
edited
Loading

@abnegate @fogelito This is the new PR for appwrite/appwrite#5376.

What's Changed?

  1. Internal attributes are selected if queried inside the getAttributeProjection method.
  2. Before the document is returned internal attributes which are not queried are removed.
  3. Added tests for getDocument, find and findOne method.
    All tests work fine (local machine).

@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
@abnegate abnegate merged commit 98dc6a9 into utopia-php:main Aug 9, 2023
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegate abnegate abnegate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faisalill @abnegate