Fallback to $id when validating select queries #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata tables for indexes and attributes does not have key property so select queries cannot be validated. We need to fallback on when key property is not present in such cases. This commit fixes that
fanatic75
changed the title
lohanidamodar
approved these changes
Aug 3, 2023
Contributor
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Approving this based on @abnegate 's comment on
appwrite/appwrite#5885 (comment)
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata tables for indexes and attributes does not have key property so select queries cannot be validated. We need to fallback on when key property is not present in such cases. This commit fixes that.
Here's a discussion with Jake on this
appwrite/appwrite#5885 (comment)