Fix-#3914-invalid-queries causes 500 error #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Dec 12, 2023
| public function isArray(): bool | ||
| { | ||
| return true; | ||
| return is_array($value); |
Contributor
There was a problem hiding this comment.
I don't think this is used, but it still shouldn't be changed so that it's consistent with others.
stnguyen90
reviewed
Dec 12, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
So, looking at the code, it looks like the Queries validator has already been updated to fix the problem so no more changes are needed.
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Enhancement 🚀
Test Invalid API Call
Added a PHPUnit test case to ensure proper validation of an invalid API call. This test checks if the
isValidmethod in theDocumentsclass correctly handles the scenario where the provided queries are not an array. The expected behavior is that the method returnsfalseand sets an error message indicating that "Queries must be an array."Code Improvement 🛠️
Enhance isArray Method
Improved the
isArraymethod in the same class (Documents) by fixing a parameter mismatch. The method now correctly checks if the provided value is an array using theis_arrayfunction, enhancing the reliability of the isArray function.These changes aim to strengthen the validation logic and improve the overall robustness of the codebase.