Fix encoding decoding #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe changes standardize internal attribute handling in the database's Changes
Sequence Diagram(s)sequenceDiagram
participant Test as PermissionTests
participant DB as Database
participant Doc as Document
Test->>DB: Create collection
Test->>DB: Create document (without permissions)
DB->>Doc: Instantiate Document (no $permissions)
Doc-->>DB: Document (with $permissions as empty array)
DB-->>Test: Document with $permissions = []
Test->>DB: Create multiple documents (bulk, no permissions)
loop For each document
DB->>Doc: Instantiate Document (no $permissions)
Doc-->>DB: Document (with $permissions as empty array)
end
DB-->>Test: Documents with $permissions = []
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
fogelito
commented
Jul 27, 2025
fogelito
commented
Jul 27, 2025
fogelito
commented
Jul 27, 2025
src/Database/Database.php
Outdated
|
|
||
| foreach ($value as &$node) { | ||
| foreach (\array_reverse($filters) as $filter) { | ||
| foreach ($value as $k => $node) { |
Member
There was a problem hiding this comment.
Let's use a better name, $key, or something more descriptive if that collides
Contributor
Author
There was a problem hiding this comment.
Changed to $index since $key is in use
abnegate
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Null permissions issue added in decode
Summary by CodeRabbit
Bug Fixes
$permissionskey set to an empty array.$permissions.$idand$permissions.Tests
$permissionskey with an empty array as its value.