Skip to content

Fix min check #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 2 commits into from
Aug 5, 2025
Merged

Fix min check #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec0e25
Fix min check
abnegate Aug 5, 2025
f948a35
Fix max 0
abnegate Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5233,7 +5233,7 @@ public function increaseDocumentAttribute(
}
}

if ($max && ($document->getAttribute($attribute) + $value > $max)) {
if (!\is_null($max) && ($document->getAttribute($attribute) + $value > $max)) {
throw new LimitException('Attribute value exceeds maximum limit: ' . $max);
}

Expand Down Expand Up @@ -5332,7 +5332,7 @@ public function decreaseDocumentAttribute(
}
}

if ($min && ($document->getAttribute($attribute) - $value < $min)) {
if (!\is_null($min) && ($document->getAttribute($attribute) - $value < $min)) {
throw new LimitException('Attribute value exceeds minimum limit: ' . $min);
}

Expand Down
28 changes: 26 additions & 2 deletions tests/e2e/Adapter/Scopes/DocumentTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Utopia\Database\Exception\Authorization as AuthorizationException;
use Utopia\Database\Exception\Conflict as ConflictException;
use Utopia\Database\Exception\Duplicate as DuplicateException;
use Utopia\Database\Exception\Limit as LimitException;
use Utopia\Database\Exception\Structure as StructureException;
use Utopia\Database\Exception\Type as TypeException;
use Utopia\Database\Helpers\ID;
Expand Down Expand Up @@ -1205,8 +1206,31 @@ public function testDecreaseLimitMin(Document $document): void
/** @var Database $database */
$database = static::getDatabase();

$this->expectException(Exception::class);
$this->assertEquals(false, $database->decreaseDocumentAttribute('increase_decrease', $document->getId(), 'decrease', 10, 99));
try {
$database->decreaseDocumentAttribute(
'increase_decrease',
$document->getId(),
'decrease',
10,
99
);
$this->fail('Failed to throw exception');
} catch (Exception $e) {
$this->assertInstanceOf(LimitException::class, $e);
}

try {
$database->decreaseDocumentAttribute(
'increase_decrease',
$document->getId(),
'decrease',
1000,
0
);
$this->fail('Failed to throw exception');
} catch (Exception $e) {
$this->assertInstanceOf(LimitException::class, $e);
}
}

/**
Expand Down