-
Notifications
You must be signed in to change notification settings - Fork 55
Optimize relationship fetching #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
32b571a
Optimize relationship fetching with batch population and performance …
cursoragent 8da5e64
Fix relationship batch processing to handle Document objects correctly
cursoragent f9a0a2d
Fix relationship access to use array syntax consistently
cursoragent 0307073
Fix recursive batch processing in relationship population
cursoragent 865eff5
Fix multi-level relationship processing using existing depth mechanism
cursoragent fdf2937
Fix nested relationship detection using fetch stack instead of depth
cursoragent 986f5db
Use batch processing at all levels consistently
cursoragent c01c352
Update all single-document methods to use batch relationship processing
cursoragent dfd1637
Fix relationship cycle detection by adding collection attribute to re…
cursoragent f5e9c28
Fix relationship assignment - set to null when related document not f…
cursoragent d3e2b21
Fix relationship stack management - use Document objects directly lik…
cursoragent f43a9c2
TEMP: Disable cycle detection to test if that's causing the issue
cursoragent ca82060
MAJOR FIX: Handle Document objects vs string IDs in relationship grou…
cursoragent a41b7ce
TEMP: Simplify cycle detection to only check max depth to test if com…
cursoragent 3d227ed
Improve cycle detection: Use property-based comparison instead of Doc…
cursoragent f6cecd6
Revert to simpler cycle detection - only check max depth
cursoragent 8b58a58
REDESIGN: Implement breadth-first cycle detection for batch processing
cursoragent a4d0222
FIX: Make cycle detection less restrictive for breadth-first processing
cursoragent 31873c7
SIMPLIFY: Much more permissive cycle detection for breadth-first proc…
cursoragent dedc488
EXPERIMENT: Remove cycle detection entirely for breadth-first processing
cursoragent 0c68374
EXPERIMENT: Pure breadth-first processing with minimal cycle prevention
cursoragent db23d76
OPTIMIZE: Map-based duplicate prevention replaces cycle detection
cursoragent 0a3ef8c
ULTIMATE OPTIMIZATION: Skip already-populated relationships + map-bas…
cursoragent 34511fe
DEBUG: Add extensive logging to track relationship population issues
cursoragent 52723c2
DEBUG: Add var_dump for animal relationships specifically
cursoragent bffb3be
MAJOR FIX: Handle multiple documents referencing same related ID in o…
cursoragent f6a05fc
CLEANUP: Remove excessive animal-specific debug output
cursoragent 52628e2
Add detailed debugging to relationship population
cursoragent cd6b022
Add simple relationship test to debug basic functionality
cursoragent 1bbc241
Add comprehensive debugging to relationship population
cursoragent 7f65e74
Add extensive debugging to relationship population flow
cursoragent 2eb50a8
Add focused debugging for nested relationship selection flow
cursoragent 400f860
Fix method signatures for breadth-first batch processing
cursoragent e0f7d28
Add debugging for relationship population flow and fix early returns
cursoragent a5710d7
Merge remote-tracking branch 'origin/main' into optimize-relationship…
abnegate 2556b52
Merge remote-tracking branch 'origin/main' into optimize-relationship…
abnegate f18a985
Merge remote-tracking branch 'origin/main' into optimize-relationship…
abnegate ff40787
Fix population
abnegate c7cfab6
Clean up
abnegate 741ef0c
Fix stan
abnegate 1af779f
Add benchmark
abnegate 5127fb9
Fix depth early exit
abnegate cfd14b7
Simplify back reference removal
abnegate 272cad8
Chunk large data for relationship finds
abnegate cc3cbcd
Update benchmark
abnegate dff915b
Increase limit
abnegate 18926bf
Fix limits
abnegate cefe7c6
Fix unit tests
abnegate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/sh | ||
|
|
||
| php /usr/src/code/bin/cli.php relationships $@ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote forwarded CLI arguments.
$@without quotes re-splits arguments containing spaces, so the CLI task receives mangled input. Wrap it in quotes.📝 Committable suggestion
🤖 Prompt for AI Agents