Don't wait to return empty

[abnegate]

Summary by CodeRabbit

• Bug Fixes
  • Updating a non-existent document now cleanly returns an empty result, preventing downstream processing and avoiding unexpected errors.
  • Skips relationship population and decoding when an update yields no document, ensuring consistent, predictable responses.
  • Delete notifications/events are only emitted when a record is actually deleted, avoiding false signals and improving system reliability.

[coderabbitai]

Walkthrough

Adds early-return guards in updateDocument to short-circuit when the old or resulting document is empty, shifts the emptiness check into the transaction, and emits DOCUMENT_DELETE events only when a deletion actually occurred. No public signatures changed.

Changes

Cohort / File(s)	Summary of Changes
Update & delete guards src/Database/Database.php	Added early-return inside the transaction when $old->isEmpty() to short-circuit update flow; removed a later redundant emptiness check; added post-transaction guard to return immediately if $document->isEmpty() before relationship population/decoding; emit DOCUMENT_DELETE event only when deletion succeeded. No public signatures changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant DB as Database
  participant Tx as Transaction

  Caller->>DB: updateDocument(collectionId, documentId, data)
  DB->>Tx: begin transaction
  Tx->>Tx: read old document
  alt old document is empty (new in-tx guard)
    Tx-->>DB: return empty Document
    DB-->>Caller: empty Document
  else old document exists
    Tx->>Tx: apply updates
    Tx-->>DB: updated Document (may be empty)
    DB->>DB: post-transaction guard checks `$document->isEmpty()`
    alt updated document is empty
      DB-->>Caller: empty Document
    else
      DB->>DB: populate relationships & decode
      DB-->>Caller: updated Document
    end
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Refactor DocumentTests to improve test coverage and structure #644 — Modifies src/Database/Database.php's updateDocument logic (how updatedAt is captured/used); likely intersects with this PR's transactional/control-flow changes.

Poem

A rabbit taps the keys—hop, hop—
If no old burrow, stop and drop.
Transactions check before we roam,
Empty finds send bunnies home.
Delete bell rings only on a true gone—hop! 🐇✨

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 42f35b7 and 82aa0e8.

📒 Files selected for processing (1)

• src/Database/Database.php (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Database/Database.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: Adapter Tests (SharedTables/MySQL)
• GitHub Check: Adapter Tests (SharedTables/Postgres)
• GitHub Check: Adapter Tests (SharedTables/SQLite)
• GitHub Check: Adapter Tests (Pool)
• GitHub Check: Adapter Tests (Mirror)
• GitHub Check: Adapter Tests (SharedTables/MariaDB)
• GitHub Check: Adapter Tests (MySQL)
• GitHub Check: Adapter Tests (Postgres)
• GitHub Check: Adapter Tests (SQLite)
• GitHub Check: Adapter Tests (MariaDB)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-update

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.