-
Notifications
You must be signed in to change notification settings - Fork 55
Feature - Strict Query Validation #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Strict Query Validation #7
Conversation
|
@kodumbeats I might also add a new collection attributed called "indexesInQueue" to hold pending indexes that are still being created, this will allow us to give a better error messages in this validator. |
|
@eldadfux I'm not 💯 on what is best to pass to the Queries validator constructor. I landed on this approach in acefb92 because passing in Maybe you have some suggestions on how to best model the new collections in the Queries unit tests: |
eldadfux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, left some minor comments. When ready I can merge it and start playing around with it :)
This PR introduces a new Queries validator to validate an array of Query objects by:
Test plan:
Unit tests included
TODO: