-
Notifications
You must be signed in to change notification settings - Fork 55
Revert "Feat mongodb" #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRemoves MongoDB support across CI, Docker, dependencies, resources, and tests. Refactors adapter interfaces by dropping casting and certain capability methods, tightening getAttributeProjection return types, and adding spatial capability checks. Updates Database core for static query conversion and relationship filter subqueries. Simplifies validators and index checks. Adjusts tests accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Database
participant Adapter
Note over Database: Query conversion now static<br/>and uses relationship filter subqueries
Client->>Database: findDocuments(collection, queries)
activate Database
Database->>Database: convertQueries(collection, queries) [static]
Database->>Database: convertRelationshipFiltersToSubqueries(relationships, queries)
Database->>Adapter: executeFind(collection, convertedQueries)
activate Adapter
Adapter-->>Database: result rows
deactivate Adapter
Database-->>Client: documents (no adapter casting hooks)
deactivate Database
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (35)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reverts #721
Summary by CodeRabbit