Skip to content

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Changed the default build output directory from ./dist to ./.output.
  • Tests
    • Updated detection tests to expect the new output directory.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

The TanStackStart framework detection was updated to use ./.output as the build output directory instead of ./dist. The change appears in the framework detector implementation and the corresponding unit test expectation; no other logic or control-flow changes are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are small and localized but affect both implementation and tests.
  • Files to inspect:
    • src/Detection/Framework/TanStackStart.php — verify the new path is intentional and consistent.
    • tests/unit/DetectorTest.php — ensure test expectations match intended behavior and no other tests rely on the old path.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Chore: Update new Nitro default' is vague and does not clearly convey what was actually changed. The PR updates the TanStack Start output directory from './dist' to './.output', but the title mentions 'Nitro' which is not present in the actual changes. Revise the title to accurately reflect the changes, such as 'Chore: Update TanStack Start default output directory to ./.output' or 'Fix: Correct TanStack Start output directory path'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-tanstack-nitro-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/unit/DetectorTest.php (1)

421-456: TanStack Start output directory assertion matches the new default

The updated expectation to './.output' is consistent with the new TanStackStart::getOutputDirectory() behavior and keeps the package-based detection path in sync.

As a small follow-up, you could also assert the output directory in testTanStackStartDetectionWithDevPackages() for symmetry with this test and to fully cover both detection paths:

         $this->assertEquals('tanstack-start', $detectedFramework->getName());
         $this->assertEquals('pnpm install', $detectedFramework->getInstallCommand());
         $this->assertEquals('pnpm build', $detectedFramework->getBuildCommand());
+        $this->assertEquals('./.output', $detectedFramework->getOutputDirectory());
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb69777 and 0ba6ee6.

📒 Files selected for processing (1)
  • tests/unit/DetectorTest.php (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/unit/DetectorTest.php (12)
src/Detection/Framework/Svelte.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Astro.php (1)
  • getOutputDirectory (64-67)
src/Detection/Framework/SvelteKit.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Lynx.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Vue.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Angular.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Analog.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/NextJs.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Nuxt.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework/Remix.php (1)
  • getOutputDirectory (46-49)
src/Detection/Framework.php (1)
  • getOutputDirectory (41-41)
src/Detection/Framework/Flutter.php (1)
  • getOutputDirectory (32-35)

@stnguyen90 stnguyen90 merged commit c1f49b3 into main Nov 24, 2025
4 checks passed
@stnguyen90 stnguyen90 deleted the fix-tanstack-nitro-default branch November 24, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants