-
Notifications
You must be signed in to change notification settings - Fork 0
Chore: Update new Nitro default #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe TanStackStart framework detection was updated to use Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/unit/DetectorTest.php (1)
421-456: TanStack Start output directory assertion matches the new defaultThe updated expectation to
'./.output'is consistent with the newTanStackStart::getOutputDirectory()behavior and keeps the package-based detection path in sync.As a small follow-up, you could also assert the output directory in
testTanStackStartDetectionWithDevPackages()for symmetry with this test and to fully cover both detection paths:$this->assertEquals('tanstack-start', $detectedFramework->getName()); $this->assertEquals('pnpm install', $detectedFramework->getInstallCommand()); $this->assertEquals('pnpm build', $detectedFramework->getBuildCommand()); + $this->assertEquals('./.output', $detectedFramework->getOutputDirectory());
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/unit/DetectorTest.php(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/unit/DetectorTest.php (12)
src/Detection/Framework/Svelte.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Astro.php (1)
getOutputDirectory(64-67)src/Detection/Framework/SvelteKit.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Lynx.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Vue.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Angular.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Analog.php (1)
getOutputDirectory(46-49)src/Detection/Framework/NextJs.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Nuxt.php (1)
getOutputDirectory(46-49)src/Detection/Framework/Remix.php (1)
getOutputDirectory(46-49)src/Detection/Framework.php (1)
getOutputDirectory(41-41)src/Detection/Framework/Flutter.php (1)
getOutputDirectory(32-35)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.