Framework V2 #102
Merged
Framework V2 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lohanidamodar
commented
Jul 6, 2023
lohanidamodar
commented
- Support server adapters
eldadfux
reviewed
Jul 11, 2023
eldadfux
requested changes
Jul 11, 2023
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Good progress. We need to test both Swoole and FPM. We should also update the readme file.
What are we doing about server initiali`ation callbacks? Can we make the server init look closer to other newer utopia libs? Take Appwrite for example, we have a lot of usage of Swoole callbacks for server start and other events. Can we abstract that nicely?
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
eldadfux
requested changes
Jul 12, 2023
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
Fix: Swoole coroutine http server
…o-v2 Add multiple validator
eldadfux
reviewed
Jan 4, 2024
eldadfux
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.