Fix null path matching #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces telemetry and compression support to the application core, adds a new Changes
Sequence Diagram(s)Telemetry and Compression in App RunsequenceDiagram
participant Client
participant App
participant Telemetry
participant Response
Client->>App: Sends HTTP Request
App->>Telemetry: Increment activeRequests
App->>Telemetry: Start requestDuration timer
App->>App: runInternal(request, response)
App->>Response: Configure compression if enabled
App->>Telemetry: Record requestBodySize
App->>App: Route matching, execution, error handling
App->>Telemetry: Stop requestDuration timer, record duration
App->>Telemetry: Decrement activeRequests
App->>Telemetry: Record responseBodySize
App->>Response: Send response
Response->>Client: Return HTTP Response
Response Compression LogicsequenceDiagram
participant App
participant Response
participant Client
App->>Response: Set Accept-Encoding, Compression Min Size, Supported Algorithms
App->>Response: Prepare response body
Response->>Client: Check Accept-Encoding, Content-Type, Body Size
alt Compressible and Acceptable
Response->>Response: Compress body, set headers
end
Response->>Client: Send (possibly compressed) response
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Meldiron
reviewed
Jul 3, 2025
| * @return string|null | ||
| */ | ||
| public static function getEnv(string $key, string $default = null): ?string | ||
| public static function getEnv(string $key, ?string $default = null): ?string |
Contributor
There was a problem hiding this comment.
We might want this change here too https://github.com/utopia-php/system/blob/main/src/System/System.php#L537
Meldiron
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix route matching when path is null
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests
Chores