Feat: Improve cookie handling #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
loks0n
approved these changes
Sep 2, 2025
abnegate
reviewed
Sep 2, 2025
abnegate
reviewed
Sep 2, 2025
abnegate
reviewed
Sep 2, 2025
Comment on lines
41
to
61
| $cookie = 'cookie1=value1'; | ||
| $response = $this->client->call(Client::METHOD_GET, '/cookies', [ | ||
| 'Cookie: cookie1=value1; cookie2=value2' | ||
| 'Cookie: ' . $cookie | ||
| ]); | ||
| $this->assertEquals(200, $response['headers']['status-code']); | ||
| $this->assertEquals($cookie, $response['body']); | ||
|
|
||
| $cookie = 'cookie1=value1; cookie2=value2'; | ||
| $response = $this->client->call(Client::METHOD_GET, '/cookies', [ | ||
| 'Cookie: ' . $cookie | ||
| ]); | ||
| $this->assertEquals(200, $response['headers']['status-code']); | ||
| $this->assertEquals($cookie, $response['body']); | ||
|
|
||
|
|
||
| $cookie = 'cookie1=value1;cookie2=value2'; | ||
| $response = $this->client->call(Client::METHOD_GET, '/cookies', [ | ||
| 'Cookie: ' . $cookie | ||
| ]); | ||
| $this->assertEquals(200, $response['headers']['status-code']); | ||
| $this->assertEquals('cookie1=value1; cookie2=value2', $response['body']); | ||
| $this->assertEquals($cookie, $response['body']); |
Member
There was a problem hiding this comment.
Let's cover case sensitivity of keys, inclusion of other attributes like path, domain, httponly, etc.
Contributor
Author
There was a problem hiding this comment.
Added case sensitivity, and few more. Attributes like path and stuff is for Set-cookie. those are given to browser, to manage cookies well, but aren't sent back to server in cookie header
abnegate
reviewed
Sep 2, 2025
abnegate
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Swoole's cookie parsing to allow us to proxy raw cookie as is