Skip to content

Issue-4370: Added Code Analyzer To utopia-php/framework #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christyjacob4 merged 10 commits into from
Apr 6, 2023
Merged

Issue-4370: Added Code Analyzer To utopia-php/framework #79

christyjacob4 merged 10 commits into from
Apr 6, 2023

Conversation

@Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 22, 2022

What

This PR aims to resolve the issue appwrite/appwrite#4370.

How

  • Code Analyzer has been added to utopia-php/framework repository.
  • All existing files are fixed as per the PhpStan rules at Level 5.
  • PR Template has been followed as mentioned in Feat: Code quality analysis ab#8.

Screenshots

PhpStan Ananlysis

Fixes appwrite/appwrite#4370

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 22, 2022

@Meldiron Please review and approve. Thanks.

@PineappleIOnic
Copy link
Contributor

PineappleIOnic commented Oct 31, 2022

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

stnguyen90
stnguyen90 requested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

stnguyen90
stnguyen90 previously requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to address the comments I previously left.

@stnguyen90 stnguyen90 self-requested a review January 27, 2023 19:08
@christyjacob4
Copy link
Contributor

christyjacob4 commented Apr 6, 2023

@Rutam21 thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@christyjacob4 christyjacob4 dismissed stnguyen90’s stale review April 6, 2023 14:57

Addressed comments

@christyjacob4 christyjacob4 merged commit 19d3925 into utopia-php:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🔎 Add Code Analyzer To ‘utopia-php/framework’

5 participants

@Rutam21 @PineappleIOnic @christyjacob4 @stnguyen90 @TorstenDittmann