Skip to content

Conversation

@abhayguptas
Copy link

Added datadog adaptor as per -> Improve Appwrite Logging with Datadog Adapter #4204

@abhayguptas
Copy link
Author

appwrite/appwrite#4204

@abhayguptas abhayguptas reopened this Nov 2, 2023
@abhayguptas
Copy link
Author

Fixes appwrite/appwrite#4204

@PineappleIOnic
Copy link
Contributor

PineappleIOnic commented Nov 6, 2023

Could you please take a look at the tests and fix the ones related to your adapter? Ignore the other ones as we'll fix those soon ourselves.

First to check the static analysis run:

docker run --rm --interactive --tty \
  --volume $PWD:/app \
  composer check

then for your normal tests run:

docker run --rm --interactive --tty \
  --volume $PWD:/app \
  ./vendor/bin/phpunit tests/e2e/Adapter/DatadogTest.php

Optionally if you don't have docker installed feel free to use GitPod to run these commands.

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@abhayguptas abhayguptas closed this by deleting the head repository Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants