-
Notifications
You must be signed in to change notification settings - Fork 66
[Docs] Removed authors in utopia-php/messaging docs #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stnguyen90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you manually update the composer.lock file? If so, would you please revert the change? The lock file is automatically generated so it wouldn't really make sense to remove the authors every time we update dependencies.
stnguyen90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see previous comment
Reverted composer.lock file and removed the new line in composer.json
Hey @stnguyen90 I committed the changes is there anymore changes |
|
Thank you so much for the PR 🤩. We're adding the |
stnguyen90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
What does this PR do?
Removes the authors from the following files
composer.json,composer.lockandReadme.mdTest Plan
NA
Related PRs and Issues
This PR is related to the issue #4406
Have you read the Contributing Guidelines on issues?
Yes