Added Gupshup Messaging Adapter #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitVashisht11
changed the title
HarshitVashisht11
changed the title
HarshitVashisht11
changed the title
wess
reviewed
Oct 12, 2023
Contributor
wess
left a comment
wess
left a comment
There was a problem hiding this comment.
Please include tests and be sure to run linter
wess
reviewed
Oct 12, 2023
Contributor
wess
left a comment
wess
left a comment
There was a problem hiding this comment.
Please be sure to add tests and run the linter (pint)
|
@HarshitVashisht11 Linter and tests are still failing, did you run linter and tests before submitting the PR? |
Author
|
Hi @wess @gewenyu99 i have made a new PR closing this PR because of some issue in commit |
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implement support for Gupshup in the Utopia PHP messaging library.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
appwrite/appwrite#6863
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)