Feat: Added Gupshup Messaging Adapter #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitVashisht11
changed the title
Author
|
Hi @gewenyu99 @wess Please review my PR |
stnguyen90
requested changes
Nov 1, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 Would you please attach screenshots of successful tests.
Author
Thanks for reviewing my PR. At the moment, I don't possess a Gupshup API key, which is why I'm unable to conduct testing. |
Contributor
So you, nor we, have any way of confirming what you did works... |
Author
|
So, is there any way I can test if my code works |
|
@HarshitVashisht11 😅 usually those who implement the code would know how it's meant to be tested. Please include and run your tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implement support for Gupshup in the Utopia PHP messaging library.
Fixes: appwrite/appwrite#6863
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)