feat: inforu sms adapter #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function getName(): string | ||
| { | ||
| return static::NAME; |
Contributor
There was a problem hiding this comment.
why static? Why not self::name ?
Member
Author
There was a problem hiding this comment.
thats what we do for Fast2SMS and others
Member
There was a problem hiding this comment.
self::NAME will return the base class value even in child classes, better to use static in most cases
| $message->getTo() | ||
| ); | ||
|
|
||
| fwrite(STDOUT, json_encode($recipients, JSON_PRETTY_PRINT)); |
Contributor
There was a problem hiding this comment.
why are we using fwrite here?
christyjacob4
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Inforu SMS adapter to reduce OTP costs in Israel region. Docs - https://apidoc.inforu.co.il/#a14d8383-8b48-4acc-9e78-48d245f2a5f0
Test Plan
Added test file.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.