Fix a team membership migration bug #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
The create team membership API fails if an invalid email, phone, or name are supplied. We can get rid of all of those params because the we can look up the user by user id and user id should always be available. In addition, the create team membership API will fail if an empty string is passed for the url. We have to use the latest SDK where we can omit the url param.
stnguyen90
force-pushed
the
fix-create-team-membership
branch
from
1f13bef to
77049ab
Compare
2 tasks
abnegate
reviewed
Sep 8, 2023
stnguyen90
force-pushed
the
fix-create-team-membership
branch
from
77049ab to
7189b2e
Compare
Using asterisks is easier to understand thant remembering what ^ and ~ mean.
stnguyen90
force-pushed
the
fix-create-team-membership
branch
from
7189b2e to
60db4c3
Compare
abnegate
approved these changes
Sep 12, 2023
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create team membership API fails if an invalid email, phone, or name are supplied. We can get rid of all of those params because the we can look up the user by user id and user id should always be available.
Related issue: