Fix: Make firebase arrays work correctly #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Feb 13, 2025
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Any test we can add to make sure this works and doesn't break in the future?
Contributor
Author
We currently do not have the ability to create a Mock API for Firebase due to the complexity in the authentication schema and all the routes we would have to emulate |
# Conflicts: # composer.lock
abnegate
reviewed
Feb 13, 2025
abnegate
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little while ago we removed the setter methods from all of our classes but forgot to update the Firebase adapter for these changes so it broke arrays when migrating documents. This PR fixes that.